Add internal/params pacakge test
#474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
=========================================
+ Coverage 7.83% 8.07% +0.23%
=========================================
Files 396 396
Lines 20320 20320
=========================================
+ Hits 1593 1640 +47
+ Misses 18490 18449 -41
+ Partials 237 231 -6
Continue to review full report at Codecov.
|
kevindiu
reviewed
Jun 15, 2020
|
/rebase |
|
[REBASE] Rebase triggered by hlts2 for branch: test/internal/params |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vdaas-ci
force-pushed
the
test/internal/params
branch
from
3f81f8e
to
e1e1446
Compare
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kevindiu
reviewed
Jun 16, 2020
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kevindiu
reviewed
Jun 16, 2020
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kevindiu
suggested changes
Jun 16, 2020
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kevindiu
reviewed
Jun 16, 2020
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
kevindiu
reviewed
Jun 16, 2020
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
kevindiu
reviewed
Jun 16, 2020
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vankichi
reviewed
Jun 17, 2020
|
/rebase |
|
[REBASE] Rebase triggered by hlts2 for branch: test/internal/params |
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vankichi
reviewed
Jun 17, 2020
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
|
/approve |
|
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
vdaas-ci
approved these changes
Jun 17, 2020
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com
Description:
I added
internal/paramspacakge test.this test' coverage is 100%.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: